Am I doing it correctly ir is there room for improvement